This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Use a dedicated server as webview domain #591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
azatsarynnyy
requested review from
benoitf,
RomanNikitenko and
vzhukovs
as code owners
February 2, 2020 18:00
This comment was marked as outdated.
This comment was marked as outdated.
benoitf
approved these changes
Feb 4, 2020
vzhukovs
reviewed
Feb 4, 2020
extensions/eclipse-che-theia-plugin-ext/src/node/plugin-service.ts
Outdated
Show resolved
Hide resolved
vzhukovs
approved these changes
Feb 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other looks good to me
RomanNikitenko
approved these changes
Feb 4, 2020
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
This comment was marked as outdated.
This comment was marked as outdated.
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) |
1 task
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* add vuejs extension * fix release date * bump node to 12 * Remove .git from repo Signed-off-by: Esteban Mañaricua <emanaricua@gmail.com> Co-authored-by: Eric Williams <ericwill@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
Uses a dedicated endpoint to deploy all webviews separately from Che Theia editor endpoint.
It increases security since all webviews don't have access to the data of Che Theia window.
Note, this PR depends on a couple of other PRs (already merged):
To test it:
quay.io/lkrejci/che-server:7.7.0-issue-15283
which includes unique endpoint featurewebviews
endpoint which is used for loading webview of Welcome pageWhat issues does this PR fix or reference?
closes eclipse-che/che#15616
Release Notes
Docs PR